Re: Increase psql's password buffer size

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Increase psql's password buffer size
Date: 2020-01-21 15:23:59
Message-ID: 20200121152359.GD7084@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 21, 2020 at 04:19:13PM +0100, David Fetter wrote:
> On Tue, Jan 21, 2020 at 10:12:52AM -0500, Bruce Momjian wrote:
> > I think we should be using a macro to define the maximum length, rather
> > than have 100 used in various places.
>
> It's not just 100 in some places. It's different in different places,
> which goes to your point.
>
> How about using a system that doesn't meaningfully impose a maximum
> length? The shell variable is a const char *, so why not just
> re(p)alloc as needed?

Uh, how do you know how big to make the buffer that receives the read?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-01-21 15:25:14 Re: We're getting close to the end of 2020-01 CF
Previous Message David Fetter 2020-01-21 15:19:13 Re: Increase psql's password buffer size