| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Luis Carril <luis(dot)carril(at)swarm64(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add FOREIGN to ALTER TABLE in pg_dump |
| Date: | 2020-01-11 01:52:53 |
| Message-ID: | 20200111015253.q6q6h4rpp37qitiv@development |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Sep 26, 2019 at 01:47:28PM +0000, Luis Carril wrote:
>
>I don't disagree with adding FOREIGN, though.
>
>Your patch is failing the pg_dump TAP tests. Please use
>configure --enable-tap-tests, fix the problems, then resubmit.
>
>Fixed, I've attached a new version.
>
This seems like a fairly small and non-controversial patch (I agree with
Alvaro that having the optional FOREIGN seems won't hurt). So barring
objections I'll polish it a bit and push sometime next week.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2020-01-11 02:01:33 | Re: How to retain lesser paths at add_path()? |
| Previous Message | Tomas Vondra | 2020-01-11 01:45:38 | Re: Amcheck: do rightlink verification with lock coupling |