| From: | Christoph Berg <myon(at)debian(dot)org> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| Date: | 2020-01-09 14:59:00 |
| Message-ID: | 20200109145900.GF4192@msg.df7cb.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Re: Robert Haas 2020-01-09 <CA+TgmoZC_6z3d5+6n1GVfy898uoBHMPPJU4-nAQLG5ZkaEyqdQ(at)mail(dot)gmail(dot)com>
> > So that raises the question: why does xenial's version of libedit
> > not match either its documentation or the distributed source code?
> > Because it doesn't.
>
> The level of effort you've put into this is extremely impressive, but
> I can't shake the feeling that you're going to keep finding issues in
> the test setup, the operating system, or the upstream libraries,
> rather than bugs in PostgreSQL. Maybe this is all just one-time
> stabilization effort, but...
Fwiw if libedit in xenial is Just Broken and fixing the tests would
just codify the brokenness without adding any value, I'll just disable
that test in that particular build. It looks like setting
with_readline=no on the make command line should work.
Christoph
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-01-09 15:13:04 | pgsql: doc: Add link to upgrading chapter to release notes |
| Previous Message | Robert Haas | 2020-01-09 14:45:20 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-01-09 15:06:06 | Re: Recognizing superuser in pg_hba.conf |
| Previous Message | Robert Haas | 2020-01-09 14:51:32 | Re: Allow 'sslkey' and 'sslcert' in postgres_fdw user mappings |