Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

From: Christoph Berg <myon(at)debian(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date: 2020-01-06 19:13:03
Message-ID: 20200106191303.GA3975@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Re: Tom Lane 2020-01-06 <3764(dot)1578323719(at)sss(dot)pgh(dot)pa(dot)us>
> > Does not work on Ubuntu bionic, xenial. (Others not tested.)
>
> Hmm ... do we care? The test output seems to show that xenial's
> 3.1-20150325-1ubuntu2 libedit is completely broken. Maybe there's
> a way to work around that, but it's not clear to me that that'd
> be a useful expenditure of time. You're not really going to be
> building PG13 for that release are you?

xenial (16.04) is a LTS release with support until 2021-04, and the
current plan was to support it. I now realize that's semi-close to the
13 release date, but so far we have tried to really support all
PG-Distro combinations.

I could probably arrange for that test to be disabled when building
for xenial, but it'd be nice if there were a configure switch or
environment variable for it so we don't have to invent it.

> > Ubuntu bionic fails elsewhere [ apparently in 006_logical_decoding.pl ]
>
> Hmm. Not related to this thread then. But if that's reproducible,

It has been failing with the same output since Jan 2, 2020, noon.

> somebody should have a look. Maybe related to
>
> https://www.postgresql.org/message-id/CAA4eK1LMDx6vK8Kdw8WUeW1MjToN2xVffL2kvtHvZg17%3DY6QQg%40mail.gmail.com

The only git change in that build was d207038053837 "Fix running out
of file descriptors for spill files."

Christoph

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-01-06 20:08:25 Re: pgsql: Remove support for OpenSSL 0.9.8 and 1.0.0
Previous Message Tom Lane 2020-01-06 17:14:25 pgsql: Add functions min_scale(numeric) and trim_scale(numeric).

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2020-01-06 19:14:41 Re: Removing pg_pltemplate and creating "trustable" extensions
Previous Message Pierre Ducroquet 2020-01-06 18:57:40 Re: [PATCH] fix a performance issue with multiple logical-decoding walsenders