Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date: 2020-01-06 23:06:28
Message-ID: 19973.1578351988@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Christoph Berg <myon(at)debian(dot)org> writes:
> Re: Tom Lane 2020-01-06 <3764(dot)1578323719(at)sss(dot)pgh(dot)pa(dot)us>
>>> Does not work on Ubuntu bionic, xenial. (Others not tested.)

>> Hmm ... do we care? The test output seems to show that xenial's
>> 3.1-20150325-1ubuntu2 libedit is completely broken. Maybe there's
>> a way to work around that, but it's not clear to me that that'd
>> be a useful expenditure of time. You're not really going to be
>> building PG13 for that release are you?

> xenial (16.04) is a LTS release with support until 2021-04, and the
> current plan was to support it. I now realize that's semi-close to the
> 13 release date, but so far we have tried to really support all
> PG-Distro combinations.

I installed libedit_3.1-20150325.orig.tar.gz from source here, and it
passes our current regression test and seems to behave just fine in
light manual testing. (I did not apply any of the Debian-specific
patches at [1], but they don't look like they'd explain much.)
So I'm a bit at a loss as to what's going wrong for you. Is the test
environment for Xenial the same as for the other branches?

regards, tom lane

[1] https://launchpad.net/ubuntu/+source/libedit/3.1-20150325-1ubuntu2

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-01-07 00:14:49 Re: pgsql: Remove support for OpenSSL 0.9.8 and 1.0.0
Previous Message Alvaro Herrera 2020-01-06 22:15:23 Re: pgsql: Update copyrights for 2020

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2020-01-06 23:07:18 Re: Removing pg_pltemplate and creating "trustable" extensions
Previous Message Stephen Frost 2020-01-06 22:45:18 GSoC 2020