Re: obsolete example

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Euler Taveira <euler(at)timbira(dot)com(dot)br>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: obsolete example
Date: 2019-11-22 00:13:20
Message-ID: 20191122001320.GA42684@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 21, 2019 at 08:19:56PM -0300, Euler Taveira wrote:
> Em qui., 21 de nov. de 2019 às 15:59, Pavel Stehule
> <pavel(dot)stehule(at)gmail(dot)com> escreveu:
>>
>> isn't src/tutorial/func.c obsolete? There is not any benefit for users.
>
> version-0 calling conventions were removed in v10. It seems an
> oversight at commit 5ded4bd2140. Tutorial needs some care (I'm not
> volunteering to improve it). I suggest unbreak the funcs module with
> 'mv funcs_new.c func.c'.

No objections from here, let's get rid of it. The docs actually make
use of the V1 versions, and funcs_new.c is not even compiled (it does
compile). Any objections to the attached? On top of moving the file,
there is one comment to update and a sentence to remove. Some
progress is always better than no progress.
--
Michael

Attachment Content-Type Size
tutorial-func-cleanup.patch text/x-diff 7.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-11-22 00:39:34 Re: obsolete example
Previous Message Gareth Palmer 2019-11-21 23:24:15 Re: [PATCH] Implement INSERT SET syntax