| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se> |
| Subject: | Re: v12.0: segfault in reindex CONCURRENTLY |
| Date: | 2019-10-13 18:14:51 |
| Message-ID: | 20191013181450.GG4475@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Oct 13, 2019 at 03:10:21PM -0300, Alvaro Herrera wrote:
> On 2019-Oct-13, Justin Pryzby wrote:
>
> > Looks like it's a race condition and dereferencing *holder=NULL. The first
> > crash was probably the same bug, due to report query running during "reindex
> > CONCURRENTLY", and probably finished at nearly the same time as another locker.
>
> Ooh, right, makes sense. There's another spot with the same mistake ...
> this patch should fix it.
I would maybe chop off the 2nd sentence, since conditionalizing indicates that
we do actually care.
+ * If requested, publish who we're going to wait for. This is not
+ * 100% accurate if they're already gone, but we don't care.
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-10-13 18:26:48 | Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12 |
| Previous Message | Tom Lane | 2019-10-13 18:10:44 | Re: [HACKERS] Deadlock in XLogInsert at AIX |