| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, buschmann(at)nidsa(dot)net, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12 |
| Date: | 2019-10-13 18:26:48 |
| Message-ID: | 17717.1570991208@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
> here is an updated patch, with the recursive CTE. I've done a fair
> amount of testing on it on older versions (up to 9.4), and it seems to
> work just fine.
Might be a good idea to exclude attisdropped columns in the part of the
recursive query that's looking for sql_identifier columns of composite
types. I'm not sure if composites can have dropped columns today,
but even if they can't it seems like a wise bit of future-proofing.
(We'll no doubt have occasion to use this logic again...)
Looks good other than that nit.
> BTW the query (including the RELKIND_COMPSITE_TYPE) was essentially just
> a lightly-massaged copy of old_9_6_check_for_unknown_data_type_usage, so
> that seems wrong too.
Yeah, we should back-port this logic into that check too, IMO.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-10-13 18:31:23 | Re: ERROR: invalid input syntax for integer: "0A000" |
| Previous Message | McLaughlin, Michael | 2019-10-13 17:44:25 | ERROR: invalid input syntax for integer: "0A000" |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2019-10-13 18:30:29 | Re: v12.0: ERROR: could not find pathkey item to sort |
| Previous Message | Justin Pryzby | 2019-10-13 18:14:51 | Re: v12.0: segfault in reindex CONCURRENTLY |