| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Non-Active links being referred in our source code |
| Date: | 2019-10-08 05:05:16 |
| Message-ID: | 20191008050516.GC1613@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 07, 2019 at 05:11:40PM +0200, Juan José Santamaría Flecha wrote:
> About the broken links in win32_port.h, they are all referring to
> ntstatus. As for first case that shows the code groups, there is an up
> to date alternative. There is also an alternative for second case that
> points to their codes and descriptions. On the other hand, the last
> case is quoting a document that is no longer available, I would
> suggest to rephrase the comment, thus eliminating the quote.
>
> Please find attached a patch with the proposed alternatives.
Thanks Juan for the patch. I have checked your suggestions and it
looks good to me, so committed. Good idea to tell about
WIN32_NO_STATUS. I have noticed one typo on the way.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-10-08 05:36:50 | Re: Updated some links which are not working with new links |
| Previous Message | Noah Misch | 2019-10-08 04:59:46 | Re: expressive test macros (was: Report test_atomic_ops() failures consistently, via macros) |