| From: | Joe Nelson <joe(at)begriffs(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | alvherre(at)2ndquadrant(dot)com, robertmhaas(at)gmail(dot)com, michael(at)paquier(dot)xyz, david(dot)rowley(at)2ndquadrant(dot)com, tomas(dot)vondra(at)2ndquadrant(dot)com, surafel3000(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Change atoi to strtol in same place |
| Date: | 2019-10-04 03:23:50 |
| Message-ID: | 20191004032350.a5lrh6yps3dmvsqn@begriffs.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kyotaro Horiguchi wrote:
> > pg_standby: -k keepfiles could not parse 'hoge' as integer
>
> I didn't checked closely, but -k of pg_standby's message looks
> somewhat strange. Needs a separator?
Good point, how about this:
pg_standby: -k keepfiles: <localized error message>
> Building a sentense just concatenating multiple nonindependent
> (or incomplete) subphrases makes translation harder.
I could have pg_strtoint64_range() wrap its error messages in _() so
that translators could customize the messages prior to concatenation.
*error = psprintf(_("could not parse '%s' as integer"), str);
Would this suffice?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-10-04 03:31:38 | Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays |
| Previous Message | Amit Langote | 2019-10-04 02:13:59 | Re: Partitioning versus autovacuum |