Re: Change atoi to strtol in same place

At Tue, 01 Oct 2019 19:32:08 +0900 (Tokyo Standard Time), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in <20191001(dot)193208(dot)264851337(dot)horikyota(dot)ntt(at)gmail(dot)com>
> Hello.
>
> At Sun, 29 Sep 2019 23:51:23 -0500, Joe Nelson <joe(at)begriffs(dot)com> wrote in <20190930045123(dot)GC68117(at)begriffs(dot)com>
> > Alvaro Herrera wrote:
> > > ... can we have a new patch?
> >
> > OK, I've attached v4. It works cleanly on 55282fa20f with
> > str2int-16.patch applied. My patch won't compile without the other one
> > applied too.
> >
> > Changed:
> > [x] revert my changes in common/Makefile
> > [x] rename arg_utils.[ch] to option.[ch]
> > [x] update @pgfeutilsfiles in Mkvcbuild.pm
> > [x] pgindent everything
> > [x] get rid of atoi() in more utilities

I didn't checked closely, but -k of pg_standby's message looks
somewhat strange. Needs a separator?

> pg_standby: -k keepfiles could not parse 'hoge' as integer

Building a sentense just concatenating multiple nonindependent
(or incomplete) subphrases makes translation harder.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center