Re: Online checksums patch - once again

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: Online checksums patch - once again
Date: 2019-09-30 12:49:44
Message-ID: 20190930124944.vn2c2y44ybxck6wa@development
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Sep 30, 2019 at 01:03:20PM +0200, Magnus Hagander wrote:
>On Thu, Sep 26, 2019 at 9:48 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
>> On 2019-Aug-26, Magnus Hagander wrote:
>> > OK, let's try this again :)
>> >
>> > This is work mainly based in the first version of the online checksums
>> > patch, but based on top of Andres WIP patchset for global barriers (
>> >
>> > )
>> >
>> > Andres patch has been enhanced with wait events per
>> >
>> > .
>> Travis says your SGML doesn't compile (maybe you just forgot to "git
>> add" and edit allfiles.sgml?):
>Nope, even easier -- the reference pgVerifyChecksums was renamed to
>pgChecksums and for some reason we missed that in the merge.
>I've rebased again on top of todays master, but that was the only change I
>had to make.
>Other than bots, this patch doesn't seem to have attracted any reviewers
>> this time around. Perhaps you need to bribe someone? (Maybe "how sad
>> your committer SSH key stopped working" would do?)
>Hmm. I don't think that's a bribe, that's a threat. However, maybe it will

IMHO the patch is ready to go - I think the global barrier solves the
issue in the previous version, and that's the only problem I'm aware of.
So +1 from me to go ahead and push it.

And now please uncomment my commit SSH key again, please ;-)


Tomas Vondra
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2019-09-30 13:34:14 Re: Implementing Incremental View Maintenance
Previous Message Dmitry Dolgov 2019-09-30 11:57:29 Re: [HACKERS] [PATCH] Generic type subscripting