Re: pg_upgrade fails with non-standard ACL

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade fails with non-standard ACL
Date: 2019-09-27 07:22:15
Message-ID: 20190927072215.GH8485@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 26, 2019 at 04:19:38PM -0400, Bruce Momjian wrote:
> On Thu, Sep 26, 2019 at 05:16:19PM -0300, Alvaro Herrera wrote:
>> On 2019-Sep-26, Bruce Momjian wrote:
>>> Well, right now, pg_upgrade --check succeeds, but the upgrade fails. I
>>> am proposing, at a minimum, that pg_upgrade --check fails in such cases,
>>
>> Agreed, that should be a minimum fix.
>
> Yes.

Agreed as well here. At least the latest patch proposed has the merit
to track automatically functions not existing anymore from the
source's version to the target's version, so patching --check offers a
good compromise. Bruce, are you planning to look more at the patch
posted at [1]?

[1]: https://www.postgresql.org/message-id/392ca335-068d-7bd3-0ad8-fdf0a45d95d4@postgrespro.ru
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-09-27 07:22:56 Re: Don't codegen deform code for virtual tuples in expr eval for scan fetch
Previous Message Christoph Berg 2019-09-27 07:20:55 Re: Unstable select_parallel regression output in 12rc1