| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_upgrade fails with non-standard ACL |
| Date: | 2019-09-26 20:19:38 |
| Message-ID: | 20190926201938.GC16366@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 26, 2019 at 05:16:19PM -0300, Alvaro Herrera wrote:
> On 2019-Sep-26, Bruce Momjian wrote:
> > Well, right now, pg_upgrade --check succeeds, but the upgrade fails. I
> > am proposing, at a minimum, that pg_upgrade --check fails in such cases,
>
> Agreed, that should be a minimum fix.
Yes.
> > with a clear error message about how to fix it.
>
> So the best solution being proposed is to reset the ACL to the default?
> So we would be forcing the user to propagate the ACL change manually,
> rather than trying to make pg_upgrade propagate it automatically. I
> suppose making pg_upgrade would be better, but I'm not sure to what
> extent that is a full solution.
Me neither, which is why I was proposing the minimum fix. We might not
know how to fix it in all case, but maybe we can detect all cases.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-09-26 20:27:04 | Re: Minimal logical decoding on standbys |
| Previous Message | Alvaro Herrera | 2019-09-26 20:16:19 | Re: pg_upgrade fails with non-standard ACL |