| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: MSVC buildfarm critters are not running modules' TAP tests |
| Date: | 2019-09-09 00:43:06 |
| Message-ID: | 20190909004306.GB2467@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Sep 08, 2019 at 07:44:16PM -0400, Tom Lane wrote:
> Yeah, perhaps, but I wasn't sure about how to do that easily.
> Feel free to add it ...
Feeding the makefile contents and then doing a lookup using =~ should
be enough. I think that we should just refactor set of routines for
fetchTests() so as it uses the flag to look after as input.
fetchRegressOpts() has tweaks for ENCODING and NO_LOCALE which don't
apply to the isolation tests so perhaps a different routine would be
better.
> Hm, yeah, if there are any such tests in those directories.
snapshot_too_old is a good example to work with.
> The whole thing should be back-patched into branches that have
> any affected tests. (But, please, not till after beta4 is
> tagged.)
Sure. Don't worry about that. I am focused on another thing lately
and it does not touch back-branches.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-09-09 03:05:39 | Re: [HACKERS] [PATCH] pageinspect function to decode infomasks |
| Previous Message | Tom Lane | 2019-09-08 23:44:16 | Re: MSVC buildfarm critters are not running modules' TAP tests |