Re: Refactoring code stripping trailing \n and \r from strings

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Refactoring code stripping trailing \n and \r from strings
Date: 2019-08-07 01:10:36
Message-ID: 20190807011036.GA2345@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 06, 2019 at 03:10:33PM -0400, Bruce Momjian wrote:
> On Thu, Aug 1, 2019 at 12:18:20PM +0900, Michael Paquier wrote:
>> b654714 has reworked the way we handle removal of CLRF for several
>> code paths, and has repeated the same code patterns to do that in 8
>> different places. Could it make sense to refactor things as per the
>> attached with a new routine in common/string.c?
>
> Yes, I think this is a good idea.

Thanks for the review, Bruce! Tom, do you have any objections?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2019-08-07 01:23:58 Re: partition routing layering in nodeModifyTable.c
Previous Message Thomas Munro 2019-08-06 23:57:23 Re: stress test for parallel workers