Re: Refactoring code stripping trailing \n and \r from strings

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Refactoring code stripping trailing \n and \r from strings
Date: 2019-08-06 19:10:33
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Aug 1, 2019 at 12:18:20PM +0900, Michael Paquier wrote:
> Hi Tom,
> b654714 has reworked the way we handle removal of CLRF for several
> code paths, and has repeated the same code patterns to do that in 8
> different places. Could it make sense to refactor things as per the
> attached with a new routine in common/string.c?

Yes, I think this is a good idea.

Bruce Momjian <bruce(at)momjian(dot)us>

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2019-08-06 19:45:12 Re: More issues with pg_verify_checksums and checksum verification in base backups
Previous Message Bruce Momjian 2019-08-06 19:01:22 Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)