| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Drop test user when done with it. |
| Date: | 2019-06-27 08:12:22 |
| Message-ID: | 20190627081222.GC3509@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Jun 26, 2019 at 03:07:33PM -0400, Stephen Frost wrote:
> Yes, thanks, and specifically this:
>
> https://www.postgresql.org/message-id/20181130163728.GE3415%40tamriel.snowman.net
>
> Adding 'DROP IF EXISTS' to the top to have things cleaned up so that the
> run can be repeated is fine. Removing things at the end of the test
> script would defeat the entire purpose of those tests.
The problem is that if you do an installcheck, then the role persists
in the instance of Postgres installed. That's not a good thing, and
contrary to the test policy. And your solution does nothing about
that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-06-27 14:53:55 | pgsql: Update comment |
| Previous Message | Amit Langote | 2019-06-27 02:32:27 | Re: pgsql: Fix partitioned index creation with foreign partitions |