Re: check_recovery_target_lsn() does a PG_CATCH without a throw

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: check_recovery_target_lsn() does a PG_CATCH without a throw
Date: 2019-06-25 01:07:50
Message-ID: 20190625010750.GC5569@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 24, 2019 at 11:27:26PM +0200, Peter Eisentraut wrote:
> Yeah but the new code already rejects those anyway. Note how
> timestamptz_in() has explicit switch cases to accept those, and we
> didn't carry those over into check_recovery_time().

Ditto. I was not paying much attention to the code. Your patch
indeed rejects anything else than DTK_DATE. So we are good here,
sorry for the noise.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-06-25 01:16:59 Re: Use of reloptions by EXTENSIONs
Previous Message Michael Paquier 2019-06-25 00:53:33 Re: fix psql \conninfo & \connect when using hostaddr