| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Comment typo in tableam.h |
| Date: | 2019-06-04 01:24:15 |
| Message-ID: | 20190604012415.5wiokl2kfelfqmxi@alap3.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-06-03 18:21:56 -0700, Ashwin Agrawal wrote:
> On Mon, Jun 3, 2019 at 5:26 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> > Hi,
> >
> > Thanks for these!
> >
> > On 2019-06-03 17:24:15 -0700, Ashwin Agrawal wrote:
> > > /*
> > > * Estimate the size of shared memory needed for a parallel scan
> > of this
> > > - * relation. The snapshot does not need to be accounted for.
> > > + * relation.
> > > */
> > > Size (*parallelscan_estimate) (Relation rel);
> >
> > That's not a typo?
> >
>
> The snapshot is not passed as argument to that function hence seems weird
> to refer to snapshot in the comment, as anyways callback function can't
> account for it.
It's part of the parallel scan struct, and it used to be accounted for
by pre tableam function...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-06-04 01:27:00 | Re: Confusing error message for REINDEX TABLE CONCURRENTLY |
| Previous Message | Ashwin Agrawal | 2019-06-04 01:21:56 | Re: Comment typo in tableam.h |