Re: New EXPLAIN option: ALL

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New EXPLAIN option: ALL
Date: 2019-05-15 16:26:17
Message-ID: 20190515162617.bu2fgroufcxaup53@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2019-05-15 11:05:31 -0400, Alvaro Herrera wrote:
> After eyeballing the giant patch set you sent[1], I think EXEC is a
> horrible keyword to use -- IMO it should either be the complete word
> EXECUTE, or we should pick some other word. I realize that we do not
> want to have different sets of keywords when using the legacy syntax (no
> parens) vs. new-style (with parens), but maybe we should just not
> support the EXECUTE keyword in the legacy syntax; there's already a
> number of options we don't support in the legacy syntax (BUFFERS,
> TIMING), so this isn't much of a stretch.

That seems too confusing.

> [1] I think if you just leave out the GUC print from the changes, it
> becomes a reasonable patch series.

Yea, it really should be small incremental changes instead of proposals
to "just change everything".

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-05-15 16:35:47 Re: error messages in extended statistics
Previous Message Alvaro Herrera 2019-05-15 16:17:29 Re: error messages in extended statistics