Re: error messages in extended statistics

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: error messages in extended statistics
Date: 2019-05-15 16:17:29
Message-ID: 20190515161729.GA17418@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2019-May-05, Tomas Vondra wrote:

> OK, so here is a patch, using elog() for all places except for the
> input function, where we simply report we don't accept those values.

Hmm, does this actually work? I didn't know that elog() supported
errcode()/errmsg()/etc. I thought the macro definition didn't allow for

Anyway, since the messages are still passed with errmsg(), they would
still end up in the message catalog, so this patch doesn't help my case.
I would suggest that instead of changing ereport to elog, you should
change errmsg() to errmsg_internal(). That prevents the translation
marking, and achieves the desired effect. (You can verify by running
"make update-po" in src/backend/ and seeing that the msgid no longer
appears in postgres.pot).

> Now, what about backpatch? It's a small tweak, but it makes the life a
> bit easier for translators ...

+1 for backpatching.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-05-15 16:26:17 Re: New EXPLAIN option: ALL
Previous Message Tom Lane 2019-05-15 15:53:13 Re: pgsql: Compute XID horizon for page level index vacuum on primary.