| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Bug in reindexdb's error reporting |
| Date: | 2019-05-11 12:09:02 |
| Message-ID: | 20190511120902.GA22757@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 11, 2019 at 10:28:43AM +0200, Julien Rouhaud wrote:
> I attach the switch refactoring that applies on top of current HEAD,
> and the reindex_system_catalogs() removal in a different patch in case
> that's too much during feature freeze.
Both Look fine to me at quick glance, but I have not tested them. I
am not sure about refactoring all the options into a structure,
perhaps it depends on what kind of patch it gives. Regarding a merge
into the tree, I think that this refactoring should wait until
REL_12_STABLE has been created. It is no time to take risks in
destabilizing the code.
Also, as this thread's problem has been solved, perhaps it would be
better to spawn a new thread, and to add a new entry in the CF app for
the refactoring set so as it attracts the correct audience? The
current thread topic is unfortunately misleading based on the latest
messages exchanged.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2019-05-11 14:29:25 | Re: pg12 release notes |
| Previous Message | Thomas Munro | 2019-05-11 09:49:49 | Re: POC: Cleaning up orphaned files using undo logs |