Re: [PATCH v4] Add \warn to psql

From: David Fetter <david(at)fetter(dot)org>
To: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH v4] Add \warn to psql
Date: 2019-05-01 07:38:57
Message-ID: 20190501073857.GY28936@fetter.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Wed, May 01, 2019 at 10:05:44AM +0300, Arthur Zakirov wrote:
> (Unfortunately I accidentally sent my previous two messages using my personal
> email address because of my email client configuration. This address is not
> verified by PostgreSQL.org services and messages didn't reach hackers mailing
> lists, so I recent latest message).
>
> On Tue, Apr 30, 2019 at 4:46 PM Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> > > Unfortunately new TAP test doesn't pass on my machine. I'm not good at Perl
> > > and didn't get the reason of the failure quickly.
> >
> > I guess that you have a verbose ~/.psqlrc.
> >
> > Can you try with adding -X to psql option when calling psql from the tap
> > test?
>
> Ah, true. This patch works for me:
>
> diff --git a/src/bin/psql/t/001_psql.pl b/src/bin/psql/t/001_psql.pl
> index 32dd43279b..637baa94c9 100644
> --- a/src/bin/psql/t/001_psql.pl
> +++ b/src/bin/psql/t/001_psql.pl
> @@ -20,7 +20,7 @@ sub psql
> {
> local $Test::Builder::Level = $Test::Builder::Level + 1;
> my ($opts, $stat, $in, $out, $err, $name) = @_;
> - my @cmd = ('psql', split /\s+/, $opts);
> + my @cmd = ('psql', '-X', split /\s+/, $opts);
> $node->command_checks_all(\(at)cmd, $stat, $out, $err, $name, $in);
> return;
> }

Please find attached :)

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachment Content-Type Size
v7-0001-Add-warn-to-psql.patch text/x-diff 7.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-05-01 10:02:48 Re: [PATCH v4] Add \warn to psql
Previous Message Arthur Zakirov 2019-05-01 07:05:44 Re: [PATCH v4] Add \warn to psql