Re: Regression test PANICs with master-standby setup on same machine

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: andres(at)anarazel(dot)de
Cc: michael(at)paquier(dot)xyz, kuntalghosh(dot)2007(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Regression test PANICs with master-standby setup on same machine
Date: 2019-04-24 08:02:28
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


At Wed, 24 Apr 2019 13:23:04 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <20190424(dot)132304(dot)40676137(dot)horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
> > > with a check that forces relative paths to be outside of PGDATA (baring
> > > symlinks). As far as I can tell convert_and_check_filename() would check
> > > just about the opposite.
> We need to adjust relative path between PGDATA-based and
> pg_tblspc based. The attached first patch does that.
> - I'm not sure it is OK to use getcwd this way. Another issue
> here is is_in_data_directory canonicalizes DataDir
> on-the-fly. It is needed when DataDir contains '/./' or such. I
> think the canonicalization should be done far earlier.
> The second attached is TAP change to support tablespaces using
> relative tablespaces.
> - This is tentative or sample. I'll visit the current discussion thread.
> The third is test for this issue.
> - Tablespace handling gets easier.
> The fourth is the fix for the issue here.
> - Not all possible simliar issue is not checked.

This is new version. Adjusted pg_basebackup's behavior to allow
relative mappings. But..

This is apparently out of a bug fix. What should I do with it?

Should we applying only 0004 (after further checking) or
something as bug fix, then register the rest for v13?


Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v2-0001-Allow-relative-tablespace-location-paths.patch text/x-patch 16.5 KB
v2-0002-Allow-TAP-test-to-excecise-tablespace.patch text/x-patch 4.9 KB
v2-0003-Add-check-for-recovery-failure-caused-by-tablespace.patch text/x-patch 2.6 KB
v2-0004-Fix-failure-of-standby-startup-caused-by-tablespace-.patch text/x-patch 4.7 KB
v2-0005-Documentation-update.patch text/x-patch 2.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2019-04-24 08:13:54 Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Previous Message David Rowley 2019-04-24 07:36:27 Re: pg_dump partitions can lead to inconsistent state after restore