Re: Should we add GUCs to allow partition pruning to be disabled?

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Should we add GUCs to allow partition pruning to be disabled?
Date: 2019-04-11 05:40:54
Message-ID: 20190411054054.GD31889@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 11, 2019 at 03:34:30PM +1200, David Rowley wrote:
> On Thu, 21 Mar 2019 at 00:51, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> > Just so I don't forget about this, I've added it to the July 'fest.
> >
> > https://commitfest.postgresql.org/23/2065/
>
> Now that we have 428b260f8, I think the version of this that goes into
> master should be more like the attached.

I tweaked this patch some more (sorry):
- remove "currently" since that's not expected to be changed (right?);
- remove "especially";
- refer to "partition hierarchies" not "partitioning hierarchies";
- rewrite bit about "When partition pruning is not possible"

Also, I noticed awhile ago while grepping for "probably be fixed in future
releases" that some items under ddl-inherit-caveats are actually possible for
relkind=p partitions in v11. I assume those will never be implemented for
inheritence partitioning, so I propose another update to docs (if preferred,
I'll bring up on a new thread).

- unique constraints on parent table;
- FK constraints on parent table;

Note that FK constraints *referencing* a partitiond table are possible in v12
but not in v11. So if there's any finer-grained update to documentation of the
individual limitations, it'd need to be tweaked for back branches (v10 and 11).

Justin

Attachment Content-Type Size
v1-0001-Reinstate-warnings-regarding-large-heirarchies.patch text/x-diff 2.1 KB
v1-0002-Document-features-of-declarative-partitioning.patch text/x-diff 1021 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Lepikhov 2019-04-11 06:10:27 Re: Failure in contrib test _int on loach
Previous Message Amit Langote 2019-04-11 05:33:57 Re: bug in update tuple routing with foreign partitions