| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Donald Dong <xdong(at)csumb(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Unified logging system for command-line programs |
| Date: | 2019-04-02 03:05:14 |
| Message-ID: | 20190402030514.GL16093@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 01, 2019 at 11:55:09AM -0700, Andres Freund wrote:
> A written upthread, I think this should have had a uniform interface
> with elog.h, and probably even share some code between the two. This is
> going in the wrong direction, making it harder, not easier, to share
> code between frontend and backend. While moving around as much code as
> we'd have had to do if we'd gone to error reporting compatible with
> elog.h.
Like Andres, I am a bit disappointed that this stuff is not reducing
the amount of diff code with ifdef FRONTEND in src/common/. This
actually adds more complexity than the original code in a couple of
places, like this one which is less than nice:
+#ifndef FRONTEND
+#define pg_log_warning(...) elog(WARNING, __VA_ARGS__)
+#else
+#include "fe_utils/logging.h"
+#endif
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-04-02 04:56:19 | Re: Checksum errors in pg_stat_database |
| Previous Message | Masahiko Sawada | 2019-04-02 02:37:56 | Re: Re: A separate table level option to control compression |