Re: [Suspect SPAM] Re: pgsql: Add pg_partition_root to display top-most parent of a partition

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: [Suspect SPAM] Re: pgsql: Add pg_partition_root to display top-most parent of a partition
Date: 2019-03-22 04:12:25
Message-ID: 20190322041225.GS20192@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Mar 22, 2019 at 01:09:23PM +0900, Amit Langote wrote:
> /* Fetch the top-most parent */
> ancestors = get_partition_ancestors(relid);
>
> Maybe, the patch should update this comment to say "Fetch the list of
> ancestors".

Perhaps so. Note that actually the list is fetched to grab the
top-most parent from it, so it sort of makes sense?

> What does "listed partition" mean? Maybe, you mean "If the input
> relation..."? How about write this as:

Input relation sounds better.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Langote 2019-03-22 04:16:16 Re: pgsql: Add pg_partition_root to display top-most parent of a partition
Previous Message Amit Langote 2019-03-22 04:09:23 Re: [Suspect SPAM] Re: pgsql: Add pg_partition_root to display top-most parent of a partition