| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Hubert Lubaczewski <depesz(at)depesz(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Segfault when restoring -Fd dump on current HEAD |
| Date: | 2019-02-28 02:10:14 |
| Message-ID: | 20190228021014.GF1617@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 27, 2019 at 12:02:43PM -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> I think we should save such a patch for whenever we next update the
>> archive version number, which could take a couple of years given past
>> history. I'm inclined to add a comment near K_VERS_SELF to remind
>> whoever next patches it.
>
> +1. This isn't an unreasonable cleanup idea, but being only a cleanup
> idea, it doesn't seem worth creating compatibility issues for. Let's
> wait till there is some more-pressing reason to change the archive format,
> and then fix this in the same release cycle.
+1. Having a comment as reminder would be really nice.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2019-02-28 02:15:29 | Re: pgsql: Avoid creation of the free space map for small heap relations, t |
| Previous Message | Tsunakawa, Takayuki | 2019-02-28 01:59:47 | RE: Libpq support to connect to standby server as priority |