| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Hubert Lubaczewski <depesz(at)depesz(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Segfault when restoring -Fd dump on current HEAD |
| Date: | 2019-02-27 17:02:43 |
| Message-ID: | 13742.1551286963@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> On 2019-Feb-27, Dmitry Dolgov wrote:
>> But I hope there are no objections if I'll then submit the original
>> changes with more consistent null handling separately to make decision
>> about them more consciously.
> I think we should save such a patch for whenever we next update the
> archive version number, which could take a couple of years given past
> history. I'm inclined to add a comment near K_VERS_SELF to remind
> whoever next patches it.
+1. This isn't an unreasonable cleanup idea, but being only a cleanup
idea, it doesn't seem worth creating compatibility issues for. Let's
wait till there is some more-pressing reason to change the archive format,
and then fix this in the same release cycle.
I'd also note that given what we've seen so far, there are going to be
some slow-to-flush-out null pointer dereferencing bugs from this.
I'm not really eager to introduce that towards the tail end of a devel
cycle.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2019-02-27 17:21:08 | Re: Segfault when restoring -Fd dump on current HEAD |
| Previous Message | Tom Lane | 2019-02-27 16:54:03 | Re: Index INCLUDE vs. Bitmap Index Scan |