Re: Prepared transaction releasing locks before deregistering its GID

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Oleksii Kliukin <alexk(at)hintbits(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Prepared transaction releasing locks before deregistering its GID
Date: 2019-02-22 23:44:43
Message-ID: 20190222234443.GC8725@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 22, 2019 at 12:17:01PM +0100, Oleksii Kliukin wrote:
> Thank you for updating the patch and sorry for the delay, it looks good to
> me, the tests pass on my system.

Thanks. I am still looking at this patch an extra time, so this may
take at most a couple of days from my side. For now I have committed
the test portion, which is independently useful and caused recovery of
multixact post-commit callbacks to never be stressed.

> Just this:
>
> @@ -844,17 +851,18 @@ TwoPhaseGetGXact(TransactionId xid)
> }
>
> /*
> - * TwoPhaseGetDummyProc
> + * TwoPhaseGetDummyBackendId
> * Get the dummy backend ID for prepared transaction specified by XID

I have not been paying much attention to this one, good catch. This
is unrelated to the patch of this thread so I have fixed it
separately.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shawn Debnath 2019-02-22 23:45:50 Re: Refactoring the checkpointer's fsync request queue
Previous Message Michael Paquier 2019-02-22 23:29:15 Re: Autovaccuum vs temp tables crash