From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Reporting script runtimes in pg_regress |
Date: | 2019-02-18 14:30:28 |
Message-ID: | 20190218143028.GA3700@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2019-Feb-18, Peter Eisentraut wrote:
> On 2019-02-15 15:54, Tom Lane wrote:
> >> We should also strive to align "FAILED" properly.
> > Hmm. The reasonable ways to accomplish that look to be either
> > (a) pad "ok" to the width of "FAILED", or (b) rely on emitting a tab.
> > I don't much like either, especially from the localization angle.
> > One should also note that FAILED often comes along with additional
> > verbiage, such as "(ignored)" or a note about process exit status;
> > so I think making such cases line up totally neatly is a lost cause
> > anyway.
>
> Yeah, not strictly required, but someone might want to play around with
> it a bit.
FWIW I don't think we localize pg_regress output currently, so that
argument seems moot ... But I think we can get away with constant four
spaces for now.
If we wanted to get really fancy, for interactive use we could colorize
the output. (I wonder if there's a way to get browsers to colorize
text/plain output somehow instead of printing the ansi codes).
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Robbie Harwood | 2019-02-18 15:02:27 | Re: [PATCH v20] GSSAPI encryption support |
Previous Message | Antonin Houska | 2019-02-18 14:21:11 | Re: Problems with plan estimates in postgres_fdw |