Re: [PATCH] xlogreader: do not read a file block twice

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
Cc: Grigory Smolkin <g(dot)smolkin(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] xlogreader: do not read a file block twice
Date: 2019-02-18 01:09:02
Message-ID: 20190218010902.GF1864@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 15, 2019 at 08:06:16AM +0900, Michael Paquier wrote:
> Thanks, I see what you have done. I cannot comment if your shortcut
> is actually fully correct based on my knowledge of this code, but
> things cannot be in the best conditions without having the WAL reader
> handle properly the limits. So I am planning to commit what you
> propose after an extra pass on it in the next couple of days or so.

And done, after doing and extra pass, doing more testing using by own
plugins, pg_waldump and more fancy stuff with a primary/standby and
pgbench.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-02-18 01:31:02 Re: Reaping Temp tables to avoid XID wraparound
Previous Message Imai, Yoshikazu 2019-02-18 00:57:17 RE: speeding up planning with partitions