RE: speeding up planning with partitions

From: "Imai, Yoshikazu" <imai(dot)yoshikazu(at)jp(dot)fujitsu(dot)com>
To: 'Amit Langote' <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: speeding up planning with partitions
Date: 2019-02-18 00:57:17
Message-ID: 0F97FA9ABBDBE54F91744A9B37151A5127E064@g01jpexmbkw24
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Sorry for my late reply. I had another work to do.

On Fri, Feb 8, 2019 at 9:13 AM, Amit Langote wrote:
> On 2019/02/08 13:44, Imai, Yoshikazu wrote:
> > 3.
> > 0001: line 1919-1920
> >
> > - break; /* always try
> to exclude */
> >
> > CONSTRAINT_EXCLUSION_ON is no longer used, so should we remove it also
> from guc parameters?
> Well, we haven't removed the "on" setting itself.

Ah, I understand.

> Okay, I've broken down those changes into separate patches, so that
> cleanup hunks are not fixed with other complex changes.
> 0001 is now a patch to remove duplicate code from set_append_rel_size.
> It combines multiple blocks that have the same body doing
> set_dummy_rel_pathlist().
> 0002 is the "overhaul inherited update/delete planning"
> 0003 is a cleanup patch that gets rid of some code that is rendered useless
> due to 0002 (partitioned tables no longer use constraint exclusion)

Thanks for doing these.

> I think 0001 can be committed on its own.


In commit message:

s/contradictory quals found/contradictory quals are found/
s/child excluded/child is excluded/

I think others in 0001 are ok.

> 0002+0003 can be committed
> together.
> 0004-0006 are the patches that were previously 0002-0004.

I will do code review of v22 patches again and send notes as soon as possible.

Yoshikazu Imai

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-02-18 01:09:02 Re: [PATCH] xlogreader: do not read a file block twice
Previous Message Michael Paquier 2019-02-18 00:26:19 Re: Re: BUG #15629: Typo in Documentation