|From:||Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>|
|To:||David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>|
|Cc:||PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>|
|Subject:||Re: Using POPCNT and other advanced bit manipulation instructions|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2019-Feb-04, David Rowley wrote:
> On Fri, 1 Feb 2019 at 11:45, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > I only have cosmetic suggestions for this patch. For one thing, I think
> > the .c file should be in src/port and its header should be in
> > src/include/port/, right beside the likes of pg_bswap.h and pg_crc32c.h.
> I've moved the code into src/port and renamed the file to pg_bitutils.c
I've pushed this now. Let's see what the buildfarm has to say about it.
> I've compiled and run make check-world on Linux with GCC7.3 and
> clang6.0. I've also tested on MSVC to ensure I didn't break windows.
> It would be good to get a few more people to compile it and run the
That's what the buildfarm is for ...
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
|Next Message||Robbie Harwood||2019-02-13 19:34:50||Re: libpq compression|
|Previous Message||Tom Lane||2019-02-13 19:11:26||Re: subscriptionCheck failures on nightjar|