Re: [PATCH] xlogreader: do not read a file block twice

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Grigory Smolkin <g(dot)smolkin(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] xlogreader: do not read a file block twice
Date: 2019-02-12 04:23:00
Message-ID: 20190212042300.GL1475@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 11, 2019 at 07:32:59PM +0300, Grigory Smolkin wrote:
> Hm, looks like it could speed up PostgreSQL recovery, but is it
> safe?

(Please avoid top-posting.)

> On 02/11/2019 07:25 PM, Arthur Zakirov wrote:
>> Grigory noticed that one of our utilities has very slow performance when
>> xlogreader reads zlib archives. We found out that xlogreader sometimes
>> reads a WAL file block twice.
>>
>> What do you think?

I think that such things, even if they look simple, need a careful
lookup, and I have not looked at the proposal yet. Could you add it
to the next commit fest so as we don't lose track of it?
https://commitfest.postgresql.org/22/
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2019-02-12 04:23:21 RE: Protect syscache from bloating with negative cache entries
Previous Message Michael Paquier 2019-02-12 04:18:19 Re: BUG #15548: Unaccent does not remove combining diacritical characters