| From: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Grigory Smolkin <g(dot)smolkin(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] xlogreader: do not read a file block twice |
| Date: | 2019-02-12 08:44:14 |
| Message-ID: | 1fa0c9fe-32a5-3ebd-e9c2-b5e2c9abc03e@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12.02.2019 07:23, Michael Paquier wrote:
>> On 02/11/2019 07:25 PM, Arthur Zakirov wrote:
>>> Grigory noticed that one of our utilities has very slow performance when
>>> xlogreader reads zlib archives. We found out that xlogreader sometimes
>>> reads a WAL file block twice.
>>>
>>> What do you think?
>
> I think that such things, even if they look simple, need a careful
> lookup, and I have not looked at the proposal yet. Could you add it
> to the next commit fest so as we don't lose track of it?
> https://commitfest.postgresql.org/22/
Of course. Agree, it may be a non trivial case. Added as a bug fix:
https://commitfest.postgresql.org/22/1994/
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2019-02-12 09:03:30 | Re: Problems with plan estimates in postgres_fdw |
| Previous Message | Pavel Stehule | 2019-02-12 08:15:34 | Re: proposal: variadic argument support for least, greatest function |