Memory contexts reset for trigger invocations

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Memory contexts reset for trigger invocations
Date: 2019-02-04 16:44:17
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


trigger.c goes through some trouble to free the tuples returned by
trigger functions. There's plenty codepaths that look roughly like:
if (oldtuple != newtuple && oldtuple != slottuple)
if (newtuple == NULL)
if (trigtuple != fdw_trigtuple)
return NULL; /* "do nothing" */

but we, as far as I can tell, do not reset the memory context in which
the trigger functions have been called.

Wouldn't it be better to reset an appropriate context after each
invocation? Yes, that'd require some care to manage the lifetime of
tuples returned by triggers, but that seems OK?

I get that most tables don't have dozens of triggers, but for more
complicated triggers/functions even a few seem like they'd matter?


Andres Freund


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-02-04 17:20:58 Re: propagating replica identity to partitions
Previous Message Alvaro Herrera 2019-02-04 16:30:41 propagating replica identity to partitions