Re: Synchronize with imath upstream

On Sun, Feb 03, 2019 at 07:07:36AM +0000, Andrew Gierth wrote:
> >>>>> "Noah" == Noah Misch <noah(at)leadboat(dot)com> writes:
>
> >> I found it much simpler to strip out -Wdeclaration-after-statement
> >> instead:
> >>
> >> $(RYU_OBJS): override CFLAGS := $(filter-out -Wdeclaration-after-statement,$(CFLAGS))
>
> Noah> The -Wno-declaration-after-statement approach takes eight lines
> Noah> of code, and the filter-out approach takes one. On the other
> Noah> hand, using $(filter-out) changes any runs of whitespace to
> Noah> single spaces ("$(filter-out foo,a b c)" yields "a b c"). We do
> Noah> risk that with CPPFLAGS and LDFLAGS in a few places. I don't want
> Noah> to proliferate that practice, because it changes semantics of
> Noah> CFLAGS containing -DFOO="arbitrary text".
>
> In that case I propose that we avoid the whole issue by removing
> -Wdeclaration-after-statement entirely.
>
> So far, expressed opinions have run about 4:2 in favour of allowing
> mixed declarations and code.

+1 for this.

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate