| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Lætitia Avrot <laetitia(dot)avrot(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance |
| Date: | 2019-02-02 02:31:51 |
| Message-ID: | 201902020231.rts4q3czbyfm@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Jan-31, Lætitia Avrot wrote:
> Hi,
>
> Thanks to Emil Iggland's kind review, I added precision on documentation
> for hyperbolic functions.
Hello
I see that in dtanh() you set errno to 0 before calling tanh(), but 1)
you don't check for it afterwards (seems like you should be checking for
ERANGE, as well as checking the return value for isinf()), and 2) you
don't do that in dsinh() and dcosh() and I'm not quite sure I see why.
What's up with that?
Thanks,
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-02-02 02:57:41 | Re: [PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs |
| Previous Message | Peter Geoghegan | 2019-02-02 02:27:51 | Re: Non-deterministic IndexTuple toast compression from index_form_tuple() + amcheck false positives |