Re: Simplify set of flags used by MyXactFlags

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Simplify set of flags used by MyXactFlags
Date: 2019-01-26 03:05:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Jan 25, 2019 at 12:30:39PM -0300, Alvaro Herrera wrote:
> I am, except that the change of "table" to "object" in xact.c line 2262
> makes the new paragraph read a bit weird -- it's now saying "if we've
> added a temp object ... Other objects have the same problem". Doesn't
> make sense. If you keep that word as "table", it works fine.

Indeed. Committed with this suggestion. Thanks for the review.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Morris de Oryx 2019-01-26 03:13:45 Re: crosstab/repivot...any interest?
Previous Message Michael Paquier 2019-01-26 03:00:53 Re: using expression syntax for partition bounds