Re: Simplify set of flags used by MyXactFlags

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Simplify set of flags used by MyXactFlags
Date: 2019-01-25 15:30:39
Message-ID: 201901251530.m4quzt632e4z@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2019-Jan-25, Michael Paquier wrote:

> On Thu, Jan 24, 2019 at 08:56:05AM -0300, Alvaro Herrera wrote:
> > Uh, I didn't think it was necessary nor desirable to rename the flag,
> > only the user-visible message.
> Oh, OK. I have overstated your comment then. Are you fine with the
> attached instead? The flag name remains the same, and the comment is
> updated.

I am, except that the change of "table" to "object" in xact.c line 2262
makes the new paragraph read a bit weird -- it's now saying "if we've
added a temp object ... Other objects have the same problem". Doesn't
make sense. If you keep that word as "table", it works fine.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-01-25 16:43:38 Re: Alternative to \copy in psql modelled after \g
Previous Message Peter Eisentraut 2019-01-25 15:19:41 Re: insensitive collations