| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: rewrite ExecPartitionCheckEmitError |
| Date: | 2018-12-28 17:52:24 |
| Message-ID: | 201812281752.evicricdva5e@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Dec-07, Robert Haas wrote:
> On Thu, Dec 6, 2018 at 5:22 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > Just on cleanliness grounds, I propose to rewrite the function in
> > $SUBJECT. I came across this while reviewing some already-committed
> > patch for partition pruning, and it's been sitting in my laptop ever
> > since.
> >
> > I think the current coding is too convoluted and hard to follow. The
> > patch makes it much simpler (IMO).
>
> I don't really think this is an improvement, but the only part I
> really dislike is s/val_desc/valdsc/. That is surely not an
> improvement in readability.
Point taken; pushed with that change.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2018-12-28 18:04:37 | Re: Making all nbtree entries unique by having heap TIDs participate in comparisons |
| Previous Message | Alvaro Herrera | 2018-12-28 17:34:44 | Re: removal of dangling temp tables |