Re: Change pgarch_readyXlog() to return .history files first

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Change pgarch_readyXlog() to return .history files first
Date: 2018-12-21 23:55:14
Message-ID: 20181221235514.GH1948@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 21, 2018 at 08:17:12AM +0200, David Steele wrote:
> I thought about doing that, but wanted to focus on the task at hand. It
> does save a strcpy and a bit of stack space, so seems like a win.
>
> Overall, the patch looks good to me. I think breaking up the if does make
> the code more readable.

Thanks for the lookups. I can see that the patch applies without
conflicts down to 9.4, and based on the opinions gathered on this
thread back-patching this stuff is the consensus, based on input from
Kyotaro Horiguchi and David Steele (I don't mind much myself). So,
any objections from others in doing so?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2018-12-22 00:21:17 Re: pgsql: Check for conflicting queries during replay of gistvacuumpage()
Previous Message Michael Paquier 2018-12-21 23:48:56 Re: [PATCH] Improve tab completion for CREATE TABLE