| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS |
| Date: | 2018-12-19 09:22:55 |
| Message-ID: | 20181219092255.GC680@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 19, 2018 at 04:26:27PM +0900, Tatsuro Yamada wrote:
> Yep, I already did that for ALTER INDEX in tab_completion_alter_index_set_statistics.patch like this:
>
> + /* ALTER INDEX <name> ALTER COLUMN <colname> SET STATISTICS */
> + else if (HeadMatches("ALTER", "INDEX") && TailMatches("SET", "STATISTICS")){
> + /* We don't complete after "SET STATISTICS" */
> + }
[Wake up, Neo]
Okay, then I propose to first extract a patch which does the following
things as a first step to simplify the follow-up work:
- No completion after "ALTER TABLE/INDEX SET STATISTICS" instead of
schemas.
- Complete "ALTER INDEX foo ALTER COLUMN SET" with STATISTICS (now this
prints parameters, which is annoying).
Then let's figure out the details for the rest.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-12-19 09:51:01 | Re: Ordered Partitioned Table Scans |
| Previous Message | Arkhena | 2018-12-19 08:44:33 | Re: What to name the current heap after pluggable storage / what to rename? |