Re: Improving collation-dependent indexes in system catalogs

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Improving collation-dependent indexes in system catalogs
Date: 2018-12-16 15:39:21
Message-ID: 20181216153921.4no3k4ljgh5gqyfb@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-Dec-15, Tom Lane wrote:

> I wrote:
> > While fooling with the idea of making type "name" collation
> > aware, it occurred to me that there's a better, more general
> > answer, which is to insist that collation-aware system catalog
> > columns must be marked with C collation.

> Concretely, this ...

Looks sane in a quick once-over.

I notice that some information_schema view columns end up with C
collation after this patch, and others remain with default collation.
Is that sensible? (I think the only two cases where this might matter
at all are information_schema.parameters.parameter_name,
information_schema.routines.external_name and
information_schema.foreign_servers.foreign_server_type.)

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-12-16 15:52:59 Re: select limit error in file_fdw
Previous Message Lætitia Avrot 2018-12-16 15:17:45 Grant documentation about "all tables"