| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Can we remove the #fdef UNUSED code from nbtxlog.c |
| Date: | 2018-12-14 00:25:52 |
| Message-ID: | 20181214002552.GE2921@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 13, 2018 at 03:28:15PM -0800, Andres Freund wrote:
> nbtxlog.c has a fairly large section of code commented out with #ifdef
> UNUSED. With a node justifying that with:
>
> + * This section of code is thought to be no longer needed, after
> + * analysis of the calling paths. It is retained to allow the code
> + * to be reinstated if a flaw is revealed in that thinking.
This comes from 3e4b7d87.
> That seems much better addressed by git revert/git log. Having a
> comment explaining facts that aren't true anymore is just plain
> confusing.
+1. It seems to me as well that this is better if just deleted.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-12-14 00:27:24 | Re: pg_partition_tree crashes for a non-defined relation |
| Previous Message | Michael Paquier | 2018-12-14 00:23:39 | Re: [HACKERS] REINDEX CONCURRENTLY 2.0 |