Re: idle-in-transaction timeout error does not give a hint

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: idle-in-transaction timeout error does not give a hint
Date: 2018-11-30 04:46:50
Message-ID: 20181130.134650.1384832545661385359.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi Ideriha-san,

>>>> Hi, it makes sense to me. One can submit transaction again same as
>>>> other cases you mentioned.
>>>>
>>>> I didn't attach the patch but according to my simple experiment in
>>>> psql the output would become the following:
>>>>
>>>> FATAL: terminating connection due to idle-in-transaction timeout
>>>> HINT: In a moment you should be able to reconnect to the
>>>> database and repeat your command.
>>>
>>>Alternative HINT message would be something like:
>>>
>>>HINT: In a moment you should be able to reconnect to the
>>> database and restart your transaction.
>>>
>>>This could make the meaning of the error (transaction aborted) cleaner and might give
>>>a better suggestion to the user.
>>
>> Agreed. Changing "command" to "transaction" seems more accurate. People might think
>> only the command they hit is not sent but transaction is still alive though it's of course unnatural
>> that transaction is alive after connection is terminated.
>>
>> In this case you could change the comment issued by other errors mentioned while you're at it.
>>
>> Regards,
>> Takeshi Ideriha
>
> I have added this to the next CF (2019-01).

Please find attached patch which addresses the point above.

BTW, would you like to be added to the CF item as a reviewer?

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

Attachment Content-Type Size
idle_in_trasaction_error_hint_v2.diff text/x-patch 684 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikhil Sontakke 2018-11-30 05:25:11 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Andrew Gierth 2018-11-30 04:38:55 Re: spurious(?) warnings in archive recovery