| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logical decoding vs. VACUUM FULL / CLUSTER on table with TOAST-ed data |
| Date: | 2018-11-28 02:31:31 |
| Message-ID: | 20181128023131.nzpaag2j2lsq6on4@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-11-28 03:06:58 +0100, Petr Jelinek wrote:
> On 28/11/2018 02:14, Andres Freund wrote:
> > On 2018-11-28 02:04:18 +0100, Tomas Vondra wrote:
> >> Pushed and backpatched to 9.4- (same as e9edc1ba).
> >
> > Backpatching seems on the more aggressive end of things for an
> > optimization. Could you at least announce that beforehand next time?
> >
>
> Well, it may be optimization, but from what I've seen the problems
> arising from this can easily prevent logical replication from working
> altogether as reorder buffer hits OOM on bigger tables. So ISTM that it
> does warrant backpatch.
I think that's a fair argument to be made. But it should be made both
before the commit and in the commit message.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2018-11-28 03:01:29 | Re: Query with high planning time at version 11.1 compared versions 10.5 and 11.0 |
| Previous Message | Tatsuro Yamada | 2018-11-28 02:27:23 | Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS |