Re: Support custom socket directory in pg_upgrade

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support custom socket directory in pg_upgrade
Date: 2018-11-23 14:07:12
Message-ID: 20181123140712.72gv6czx7jrflnkx@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2018-Nov-12, Tom Lane wrote:

> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> > On 12/11/2018 20:00, Tom Lane wrote:
> >> Also, even if we had an arguably-better idea, I suspect that there would
> >> always be cases where it didn't work. For example, one idea is to make
> >> a temporary directory under the installation's normal socket directory
> >> (thus, /tmp/pgXXXX/ or some such). But, if the normal socket directory
> >> is not /tmp, we might find that pg_upgrade can't write there.
> > We do exactly that in pg_regress and it's never been a problem.
> Yeah, but pg_upgrade is used by a much wider variety of people
> than pg_regress.

Surely they can just set TMPDIR if /tmp is not writable? If TMPDIR is
set and not writable, bark at the user for it.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Sergey Cherkashin 2018-11-23 14:13:24 Re: Psql patch to show access methods info
Previous Message Rushabh Lathia 2018-11-23 13:17:43 Re: Hitting CheckRelationLockedByMe() ASSERT with force_generic_plan